starlingx
/
upstream
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 31646 \u003c31646@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 8768 \u003c8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
This commit is contained in:
Gerrit User 8768 2023-10-23 22:20:41 +00:00 committed by Gerrit Code Review
parent 39f4ce9f8c
commit 1a8c9c1f7e
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
eb557c0450684931b48b6975c80f8ce05f45a3d4
View File

@ -34,6 +34,24 @@
"parentUuid": "4961509b_c4605257",
"revId": "eb557c0450684931b48b6975c80f8ce05f45a3d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "476c317b_03bf6036",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 8768
},
"writtenOn": "2023-10-23T22:20:41Z",
"side": 1,
"message": "If it\u0027s okay to make the change in ownership for ldap users, why isn\u0027t it okay for other users? (And where is this check for ldap users being made?)\n\nAlso, doing it this way we\u0027re still going to have a (likely short) window of time where the permissions are going to prevent \"source /etc/platform/openrc\" from working for anyone but root.",
"parentUuid": "21e9755b_a99c65b0",
"revId": "eb557c0450684931b48b6975c80f8ce05f45a3d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}